Small documentation update #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
oskooi
approved these changes
Dec 3, 2023
There was a problem hiding this comment.
LGTM.
Thanks for putting this together. I think it would be good to also update the top-left figure (plot of reflectance vs. incident angle for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the normal (not BFAST) notebook for the "Angular Reflectance Spectrum of a Planar Interface" documentation, the concluding markdown cell has an image with four plots; however, only three are created in the following code cells. Additionally, though the text mentions the Brewster's angle, the upper left plot in the quadrant does not seem to show the Brewster's angle behavior clearly. Added the code for the plot and increased the range to show the reflection minimum.
This is my first try using Github! Thank you, maintainers, for all of your work on MEEP.