fix off-by-one bug in dimensions of fixed-resolution MaterialGrid for adjoint-solver functions #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Sep 27, 2021
oskooi
force-pushed
the
matgrid_offbyone
branch
from
cd3128a to
d1bf38b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
==========================================
+ Coverage 74.39% 74.41% +0.02%
==========================================
Files 13 13
Lines 4581 4581
==========================================
+ Hits 3408 3409 +1
+ Misses 1173 1172 -1
|
4 tasks
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
… adjoint-solver functions (NanoComp#1769) * fix off by one bug in MaterialGrid dimensions of adjoint solver functions * adjust tols * formatting fixes * add 1 after dividing by 2 * change design_shape to design_region_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several instances of a bug involving the dimensions of a
MaterialGridwith fixed resolution. This bug was originally reported in #1760.Also, the resolution used in the unit test
test_adjoint_solver.pyis slightly increased in order to reduce the hard-coded tolerances used to compare values.