Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown documentation for stop_when_dft_decayed #1759

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Sep 18, 2021

Markdown documentation for stop_when_dft_decayed (which was missing from #1740).

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2021

Codecov Report

Merging #1759 (7ee74bf) into master (81f2081) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
- Coverage   74.39%   74.33%   -0.06%     
==========================================
  Files          13       13              
  Lines        4553     4555       +2     
==========================================
- Hits         3387     3386       -1     
- Misses       1166     1169       +3     
Impacted Files Coverage Δ
python/simulation.py 76.69% <66.66%> (-0.11%) ⬇️
python/geom.py 94.15% <0.00%> (ø)

@stevengj stevengj merged commit f5b60e5 into NanoComp:master Sep 22, 2021
@oskooi oskooi deleted the stop_when_dft_decayed_docs branch September 22, 2021 01:24
mawc2019 pushed a commit to mawc2019/meep that referenced this pull request Nov 3, 2021
* documentation for stop_when_dft_decayed

* fix

* replace TypeError with ValueError for required arguments

* show DFT decay status in output when verbosity > 1

* use default value for tol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants