Assign ranks to leaves of binary partition in depth-first order #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given this change it seems like you should also change Line 134 in 89c9349 to simply: const int proc = ids[i] % count_processors();both for simplicity and to ensure that the chunk process id is set consistently with the value in the binary tree. |
|
Good suggestion. I have made the change. |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…Comp#1681) * assign ranks to leaves of binary partition in depth-first order * ensure proc_id is not larger than number of processors * simplify setting of chunk process ID
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
…Comp#1681) * assign ranks to leaves of binary partition in depth-first order * ensure proc_id is not larger than number of processors * simplify setting of chunk process ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug described in #1673 (comment).
With this change, the unit test added in #1673 for
test_chunk_layout.pypasses and thus #1673 needs only to be rebased after this is merged.