Store the binary partition in structure
#1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Store the binary partition - whether passed in externally or generated via `choose_chunkdivision` in `structure` and expose it via a getter. * Remove the unused default constructor of `structure`. * Remove a redundant copy constructor of `structure`. * Clean up the copy constructor `structure`. * Make `binary_partition` copyable. Prepares for making the BinaryPartition visible in Python (NanoComp#1648).
|
LGTM, thanks. |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Store the binary partition - whether passed in externally or generated via `choose_chunkdivision` in `structure` and expose it via a getter. * Remove the unused default constructor of `structure`. * Remove a redundant copy constructor of `structure`. * Clean up the copy constructor `structure`. * Make `binary_partition` copyable. Prepares for making the BinaryPartition visible in Python (NanoComp#1648).
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* Store the binary partition - whether passed in externally or generated via `choose_chunkdivision` in `structure` and expose it via a getter. * Remove the unused default constructor of `structure`. * Remove a redundant copy constructor of `structure`. * Clean up the copy constructor `structure`. * Make `binary_partition` copyable. Prepares for making the BinaryPartition visible in Python (NanoComp#1648).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via
choose_chunkdivisioninstructureand expose it via a getter.structure.structure.structure.binary_partitioncopyable.Prepares for making the BinaryPartition visible in Python (#1648).