fix(otlp): manual span #3647
Open
fix(otlp): manual span #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
reviewed
Mar 10, 2025
| syncJobId?: number | undefined; | ||
| track_deletes?: boolean; | ||
| attributes?: object | undefined; | ||
| abortSignal?: AbortSignal; | ||
| syncConfig: DBSyncConfig; | ||
| runnerFlags: RunnerFlags; | ||
| /** | ||
| * @deprecated not used | ||
| */ |
There was a problem hiding this comment.
is only debug deprecated?
| @@ -21,8 +21,7 @@ export function initSentry({ dsn, hash, applicationName }: { dsn: string | undef | |||
| Sentry.init({ | |||
| dsn: dsn || '', | |||
| sampleRate: 1, | |||
| tracesSampleRate: 0, | |||
| openTelemetryInstrumentations: [], | |||
| skipOpenTelemetrySetup: true, | |||
There was a problem hiding this comment.
can we add a comment to explain why we set skipOpenTelemetrySetup to true?
| @@ -92,6 +93,7 @@ export async function startSync(task: TaskSync, startScriptFn = startScript): Pr | |||
| meta: { scriptVersion: syncConfig.version } | |||
| } | |||
| ); | |||
| logCtx.attachSpan(new OtlpSpan(logCtx.operation, startedAt)); | |||
There was a problem hiding this comment.
I am not a huge fan of this pseudo independent attachSpan function that we need to sprinkle all over the codebase.
Since it always depends on a logContextGetter.create why not making it a part of it.
can logContextGetter.create take a otlpSpan?: { startedAt?: Date } params. When it is passed the create function can set span = new OtlpSpan(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Contributes to https://linear.app/nango/issue/NAN-2803/investigate-otlp-export
Manually declare OTLP span
We need to dissociate span creation from logCtx, because getting the operation entirely from ES is not a viable solution. This fix only changes Span to be declared manually but does not fix the main issue. Just wanted to be sure it was doable and limit the scope of this PR.
Fix nangoProps type
Fix OTLP export broken by Sentry (skipOtel)