Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Added support to control the use of IApplicationStartup and IRequestStartup implementations from Browser based tests #2026

Merged
merged 1 commit into from
Aug 26, 2015

Conversation

thecodejunkie
Copy link
Member

We will always register the ones bundled with Nancy, but from tests you can not control how user-defined implementations should be registered (automatic, never, user-defined implementations)

New methods on the ´ConfigurableBootstrapperConfigurator`

ApplicationStartupTask<T>() where T : IApplicationStartup
ApplicationStartupTasks(params Type[] types)

RequestStartupTask<T>() where T : IApplicationStartup
RequestStartupTasks(params Type[] types)

DisableAutoApplicationStartupRegistration();
DisableAutoRequestStartupRegistration();

Resolves #1793

…tartup implementations from Browser based tests
@@ -538,7 +538,7 @@ public void Should_override_default_user_agent_when_explicitly_defined()

// Then
header.ShouldEqual(expectedHeaderValue);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: 🔥

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even going to give me a chance to remove the whitespace?! :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the rest was nice, so why bother 😛

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually running that, but I was not on the machine I used to send the PR :P

khellang added a commit that referenced this pull request Aug 26, 2015
Added support to control the use of IApplicationStartup and IRequestStartup implementations from Browser based tests
@khellang khellang merged commit 1b0c4f4 into NancyFx:master Aug 26, 2015
@khellang khellang mentioned this pull request Aug 26, 2015
@thecodejunkie thecodejunkie deleted the nancy-testing-startup-tasks branch February 17, 2016 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants