Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Implemented new configuration API #2003

Merged
merged 20 commits into from
Nov 7, 2015
Merged

Implemented new configuration API #2003

merged 20 commits into from
Nov 7, 2015

Conversation

thecodejunkie
Copy link
Member

See #1999 for more details on the contents of this post

@thecodejunkie thecodejunkie self-assigned this Aug 11, 2015
@thecodejunkie thecodejunkie added this to the 2.0 milestone Aug 11, 2015
@thecodejunkie thecodejunkie mentioned this pull request Aug 11, 2015
Closed
@jchannon
Copy link
Member

:shipit:

horsdal
horsdal reviewed Aug 14, 2015
View reviewed changes
src/Nancy.Tests/Unit/Bootstrapper/NancyBootstrapperBaseFixture.cs
@@ -465,6 +475,14 @@ public void Dispose()
public bool Disposed { get; private set; }
}

internal class FakeEnvironmentalConfigurator : INancyEnvironmentConfigurator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Environmental should just be Environment

@horsdal
Copy link
Member

horsdal commented Aug 14, 2015

How about INancyEnvironment implements 2 interfaces. A mutable one and an immutable one. The environment is passed as the mutable interface into .Configure, but only registered in the container as the immutable one. Defaults could then be overriden in Configure but module etc. taking a dependency on the environment could only read.

@thecodejunkie
Copy link
Member Author

Thanks @horsdal updated the code according to your review comments!

@phillip-haydon
Copy link
Member

👍

@thecodejunkie thecodejunkie mentioned this pull request Aug 16, 2015
Merged
@thecodejunkie thecodejunkie changed the title Nancy configuration feature Implemented new configuration API Aug 21, 2015
@khellang khellang mentioned this pull request Aug 31, 2015
Open
@thecodejunkie thecodejunkie force-pushed the nancy-configuration-feature branch from cefac6e to 0904490 Compare November 7, 2015 13:35
@thecodejunkie
Copy link
Member Author

Rebased against latest v2 branch. We need to pull this before we merge v2 into master .. same with #2012 after I've rebased it

jchannon added a commit that referenced this pull request Nov 7, 2015
@jchannon
Merge pull request #2003 from NancyFx/nancy-configuration-feature
402d044 
Implemented new configuration API
@jchannon jchannon merged commit 402d044 into v2 Nov 7, 2015
@thecodejunkie thecodejunkie deleted the nancy-configuration-feature branch November 7, 2015 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@thecodejunkie thecodejunkie

Labels
Breaking Change Feature Update Documentation
Projects
None yet
Milestone
2.0-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@thecodejunkie @jchannon @horsdal @phillip-haydon