API error 0 when calling setDiscordRoles with empty role list

[Sylensky]

Describe the issue
I have a very specific case of an group sync issue within the latest version.
On my ingame server i run discordsrv which syncs my ranks to my discord and from there nameless link fowards the role changes to my v2pr10 nameless homepage.
Thing is role remove and add requests are happening so fast that i think the homepage drops one event and returns the api error 0. For example: mc -> discord: role has been set, dc removes old role and adds new role. discord -> homepage: notices role remove event - executes it and drops the newly assigned role change. Interestingly manual(slow) reassigning a role on discord makes the syncing work properly.
Atleast thats what i observed down below on the logs of nameless link. Furthermore i didn't noticed any logs related to an issue with assigning the role.

To Reproduce
Steps to reproduce the behaviour:

1. setup group sync on nameless
2. setup the nameless link bot
3. setup discordsrv on the mc server
4. assign a new role to a player ingame and check discord logs and nameless-link logs
5. observe the role not getting assigned instead the default role is shown for that player

Expected behaviour
properly synced group

Screenshots

NamelessMC version (from StaffCP -> Overview)
Running NamelessMC version 2.0.0-pr10
PHP 7.4.21
PHP GD 7.4.21
PHP mbstring 7.4.21
PHP PDO 7.4.21
PHP cURL 7.4.21
PHP XML 7.4.21
PHP EXIF 7.4.21
PHP MySQL
core/config.php Writable
Cache Writable
Template Cache Writable

Additional information
Previously i was talking to derkades to embed a queue like system for role changes to improve race condition handling. Maybe this would also help in this particular case.

[tadhgboyle]

@Derkades

[Derkades]

Previously i was talking to derkades to embed a queue like system for role changes to improve race condition handling. Maybe this would also help in this particular case.

This has already been implemented: NamelessMC/Nameless-Link#207. Weren't you running this version during your tests? You should see the "checking user {} guild {} with {} items left in queue" at most once every two seconds.

[Sylensky]

Yes i was using the queue system already but you told me to create a ticket on nameless itself as the issue in the screenshot seems to be a homepage issue rather then a nameless link issue.

[Derkades]

Yes, but since you are using the queue system I don't think this is a "race condition" or in any way related to role changes in quick succession. What happens if you only cause one change role event?

[Sylensky]

If i remove a role from a user on discord and assign a new one it works. That made me think it works when executed slowly enough.

[Derkades]

Can you check if the queue works, so if the "checking user" messages are at least 2 seconds apart?

[Sylensky]

Ok i did check if they are apart and that does look fine. Apparently during testing i noticed the API error 0 is actually occuring when the role of the user on discord got removed - so he has no roles at all. Below is what the link logs say:

The logs when i assign him a new role look like this:

[Sylensky]

Additionally to provide more information i did some further testing. I did add a role to a player ingame via luckperms editor which triggers discordsrv to update the users role in discord which also triggers nameless link to update the users group on the homepage:

From the logs it looks fine that the rank got assigned but on the group sync logs there is only the remove event listed:

Unfortunately i couldnt find anything else in the logs.

[Derkades]

Cannot reproduce myself, this is what happens when I add one role and remove that role:

[JDA [1 / 2] MainWS-ReadThread] INFO Group sync discord->website - Received guild member role add event for 183954832485253121 in 776921071953772615, adding to queue
[pool-2-thread-1] INFO Group sync discord->website - Checking user 183954832485253121 guild 776921071953772615 with 0 items left in queue
[pool-2-thread-1] INFO Group sync discord->website - Sucessfully sent roles to website: guildid=776921071953772615 userid=183954832485253121 roles=[785970326030778408]
[JDA [1 / 2] MainWS-ReadThread] INFO Group sync discord->website - Received guild member role remove event for 183954832485253121 in 776921071953772615, adding to queue
[pool-2-thread-1] INFO Group sync discord->website - Checking user 183954832485253121 guild 776921071953772615 with 0 items left in queue
[pool-2-thread-1] INFO Group sync discord->website - Sucessfully sent roles to website: guildid=776921071953772615 userid=183954832485253121 roles=[]

[Sylensky]

Did you add roles "by hand" or with a third party accessing discord?

[Derkades]

By hand. While testing a bit more I did find a new issue: #2384. I'm not getting it to produce API error 0 though.

[Sylensky]

Can you try it out with a spigot server and the discordsrv plugin? Iam very confident that you will get there the api error 0.
If you need details about discordsrv hit me up on discord.

[Derkades]

@samerton is it possible to make the API endpoint provide more useful information other than just API error 0 without meta?

[partydragen]

The setDiscordRoles have been completely rewritten and have tested alot so it looks like it work now

As for the log that was a bug too, as added value did not register the group successfully
I can't see any reason of this error to happen, atleast not with this rewrite

[Derkades]

It works for me

[Sylensky]

I can confirm that this issue is resolved with the revamp of the endpoint.