Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests extended #7

Merged
merged 19 commits into from
Mar 18, 2024
Merged

Tests extended #7

merged 19 commits into from
Mar 18, 2024

Conversation

federicomarini
Copy link
Collaborator

Extending the suite of tests for the other functions, covering most use and edge cases.

We might need a couple of checks inside the function iSEEinit(), to verify that what the user wants is possible

Some examples:

  • the features are in (checking the rownames)
  • the relevant colData are really available (param vs the names)
  • the logical switches for the board and the dynamic marker table are indeed logicals.

This is minor but would reinforce the behavior even more.
Wanna give it a go @NajlaAbassi ? (and yes, "checking the GeneTonic repo" might be a fitting approach... 😉 )

@federicomarini
swift rewording
bded9bf
@federicomarini
renaming test file, moving intro parts into the setup script
73ca2ad
@federicomarini
tests setup file
ad2e74b
@federicomarini
using allen for most test suites
61746ac
@federicomarini
little bit of polishing the vignette
6edb4b3
@federicomarini
covering extra cases where params are activated
3242d91
@federicomarini
checking the contents of the returned object as well
a0e1c01
@federicomarini
full set of tests for the utilities functions
c468058
@federicomarini
version bump to 0.3.0, will head towards 0.99.0 once ready for submis…
6bffc31 
…sion
@federicomarini
adding required imports
9499dfa
@federicomarini
tests on parameters for the main function
c264329
@federicomarini
adding tests for iSEEnrich and fixing typo, also changing the example…
1fef08c 
… dataset for compact runtime
@federicomarini
full test suite for iSEEnrich
5602aa2
@federicomarini
adjust the vignette reflecting latest changes
eac6e46
@federicomarini
re-rendering manpages
c196892
@federicomarini
indenting a bit the whole ultralong lines
27b8e86
@federicomarini
adding org.Mm.eg.db to the suggested dependencies to run the vignette…
985165d 
… correctly
federicomarini
federicomarini commented Mar 18, 2024
View reviewed changes
Copy link
Collaborator Author

@federicomarini federicomarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, just need the bump to 0.99.0

@federicomarini federicomarini merged commit 6fd5266 into main Mar 18, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@federicomarini