Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert temp path completion when resolved upstream #64

Closed
Nagasaki45 opened this issue Mar 29, 2020 · 2 comments
Closed

Revert temp path completion when resolved upstream #64

Nagasaki45 opened this issue Mar 29, 2020 · 2 comments

Comments

@Nagasaki45
Copy link
Owner

We hacked together a temporary path completion in #38 / #61. The issue should hopefully be solved by click itself (follow pallets/click#780 & pallets/click#782). Revert the temporary fix when there's a solution upstream.

@Nagasaki45
Copy link
Owner Author

Nagasaki45 commented May 13, 2021

Hi @Kappers! Click 8 was just released, with support for path completion. Tested it now and it looks like we don't need to do anything to get automatic path completion. Feel bad for deleting a bunch of your code from the repo, but I guess that's for good. Feel free to test / comment, and thanks for the contribution again. EDIT: The new path completion is in bibo 1.5.0 which is now available from pypi.

@Kappers
Copy link
Contributor

Kappers commented May 21, 2021

@Nagasaki45 Sorry for being slow, I was on holiday! I think it's great that click provides support for this, thanks for reverting this band-aid 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants