Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GPIO and flow control bootloader reset #94

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Jan 13, 2025

To allow other reset patterns to be used in the future (if needed) and to consolidate the GPIO logic, I've merged the GPIO and flow control bootloader reset patterns. This is in preparation for flow control in the web flasher: NabuCasa/sl-web-tools#20

@puddly
Copy link
Collaborator Author

puddly commented Jan 13, 2025

Should fix darkxst/silabs-firmware-builder#172 with the above patch, @darkxst

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 32.81250% with 43 lines in your changes missing coverage. Please review.

Project coverage is 66.23%. Comparing base (b009196) to head (ad6d6f5).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
universal_silabs_flasher/gpio.py 25.00% 15 Missing ⚠️
universal_silabs_flasher/common.py 20.00% 12 Missing ⚠️
universal_silabs_flasher/flasher.py 7.69% 12 Missing ⚠️
universal_silabs_flasher/flash.py 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #94      +/-   ##
==========================================
+ Coverage   61.78%   66.23%   +4.44%     
==========================================
  Files          14       15       +1     
  Lines        1748     1851     +103     
==========================================
+ Hits         1080     1226     +146     
+ Misses        668      625      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly merged commit 7301770 into NabuCasa:dev Jan 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants