Skip to content
This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Fix disconnect #68

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Fix disconnect #68

merged 2 commits into from
Nov 5, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 5, 2021

  • Always fire disconnect event when read loop finishes
  • On close, wait till the read loop is finished
  • Breaking change: Reset but don't close the serial port on closing ESP Web Flasher. It's passed in in the open state, so it's up to the caller to close the port.

@balloob balloob merged commit 9cd1c74 into main Nov 5, 2021
@balloob balloob deleted the fixes branch November 5, 2021 06:00
@TD-er
Copy link

TD-er commented Nov 5, 2021

Hmm this last remark about keeping the serial port open gives me an idea.
Would it be possible to schedule a number of calls to the node after some delay, or maybe even after reading back some specific string?
This would allow to enter some credentials to be sent via the serial port at the initial boot.

@balloob
Copy link
Member Author

balloob commented Nov 5, 2021

Yes, that is possible and that's what we're doing with ESP Web Tools v2. It supports sending credentials using the new Improv over Serial

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants