Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expiration logic for banned books #1012

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

russellcullen
Copy link
Contributor

What's this do?
Updates the expiration logic from removing all 'Books For All' books that are expired, to instead check only Axis 360 distributed 'Books For All' publications and delete those which are expired or have a missing expiration date.

Axis 360 publications in the Books For All collection are all Banned Books publications. So anything Axis360 without an expiration date was acquired before the expiration logic and should be removed; and anything with an expiration date can be checked against that date.

Why are we doing this? (w/ JIRA link if applicable)
[Quick blurb about why the code is needed and Jira link goes here / Do these changes meet the business requirements of the story?]

How should this be tested? / Do these changes have associated tests?
[Description of any tests that need to be performed once merged goes here]

Dependencies for merging? Releasing to production?
[Description of any watchouts, dependencies, or issues we should be aware of goes here]

Has the application documentation been updated for these changes?

Did someone actually run this code to verify it works?

@russellcullen russellcullen merged commit 781e4e2 into develop Oct 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant