1595/manage subscriptions front end #1602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pratishta
force-pushed
the
1595/manage-subscriptions-front-end
branch
from
54ea510
to
42a634a
Compare
Clean up log and commented out code More console statements removed Add language and icons to modal
pratishta
force-pushed
the
1595/manage-subscriptions-front-end
branch
from
42a634a
to
168b5d4
Compare
TylerMatteo
requested changes
Nov 25, 2024
There was a problem hiding this comment.
@pratishta @dhochbaum-dcp Just some code quality stuff to fix - otherwise lgtm
TylerMatteo
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create new page for managing subscriptions, pre-populated with existing user subscriptions:
/subscribers/<id>idroute param.Tasks/Bug Numbers
Closes #1595 and #1599
Technical Explanation
Any other info you think would help a reviewer understand this PR?