[#131] Fix skimage SSIM win_size error #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jaeheungs , confirmed - I finally hit this bug as well with a different skimage version. |
orperel
pushed a commit
to AvivSham/kaolin-wisp
that referenced
this pull request
May 30, 2023
…s#133) Addressing github issue NVIDIAGameWorks#131 : NVIDIAGameWorks#131 Fixes: the demos on the README leads to an error due to skimage thinking that the color channel for the images used for SSIM are part of the image dimension rather than channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #131
Running the demos on the README leads to an error due to skimage thinking that the color channel for the images used for SSIM are part of the image dimension rather than channels.
Maybe the tests have been run with a different version of skimage?
Running the demo script:
python3 app/nerf/main_nerf.py --config ./app/nerf/configs/nerf_hash.yaml --dataset-path path/to/dataset/ --dataset-num-workers 4works for me after this edit.