Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Correct install(PATTERN) to match end of filenames #1825

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Correct install(PATTERN) to match end of filenames #1825

merged 1 commit into from
Nov 9, 2022

Conversation

robertmaynard
Copy link
Collaborator

The PATTERN matches at the end of filenames not the front, so we need to specify *.cmake.in to exclude the template files.

@robertmaynard robertmaynard added type: bug: functional Does not work as intended. area: cmake Related to CMake infrastructure. labels Nov 8, 2022
@jrhemstad jrhemstad requested a review from alliepiper November 8, 2022 19:49
gevtushenko
gevtushenko suggested changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment as on the CUB side of this PR. *.cmake.in files are used below to generate *.cmake files on the installation side. I don't see why we need *.cmake.in files in the installation. Unless I'm missing something, let's remove this.

@gevtushenko gevtushenko merged commit 772c0f4 into NVIDIA:main Nov 9, 2022
@robertmaynard robertmaynard mentioned this pull request Dec 21, 2022
Closed
@robertmaynard robertmaynard deleted the correct_cmake_install_rules branch December 21, 2022 14:36
@robertmaynard robertmaynard mentioned this pull request Jan 3, 2023
Open
@alliepiper alliepiper added this to the 2.1.0 milestone Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gevtushenko gevtushenko gevtushenko approved these changes

@alliepiper alliepiper Awaiting requested review from alliepiper

Assignees
No one assigned
Labels
area: cmake Related to CMake infrastructure. type: bug: functional Does not work as intended.
Projects
CCCL
Archived in project
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @gevtushenko @alliepiper