This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Remove usage of find_path to locate thrust/version.h #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a consumer of Thrust uses the CMake `FIND_ROOT_PATH_MODE_INCLUDE` option it will cause all find_path searches to only occur under the find root path. Since this normally doesn't include the source files, it means that thrust-header-search.cmake will fail to find the thrust/version.h file. This issue was found when using conda-build on a project that includes Thrust, since conda-build sets up a cross compilation enviornment including a find root path.
|
This change has also been proposed for both cub and libcudacxx |
alliepiper
approved these changes
Jul 20, 2022
|
run tests |
alliepiper
added
type: bug: functional
Co-authored-by: Allison Vacanti <[email protected]>
|
run tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a consumer of Thrust uses the CMake
FIND_ROOT_PATH_MODE_INCLUDEoption it will cause all find_path searches to only occur under the find root path. Since this normally doesn't include the source files, it means that thrust-header-search.cmake will fail to find the thrust/version.h file.This issue was found when using conda-build on a project that includes Thrust, since conda-build sets up a cross compilation
enviornment including a find root path.