Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Missing macro wrapper for zip_function #1715

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

mfbalin
Copy link
Contributor

@mfbalin mfbalin commented Jun 8, 2022

thrust::make_zip_function didn't work with device c++ lambdas as input, this patch suggested by @jrhemstad adds the macro wrapper __thrust_exec_check_disable__ to fix it.

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@jrhemstad
Copy link
Collaborator

okay to test

@jrhemstad jrhemstad added P1: should have Necessary, but not critical. backend: CUDA Related to the CUDA backend labels Jun 8, 2022
@jrhemstad
Copy link
Collaborator

ok to test

@jrhemstad jrhemstad added the type: cleanup Modernization, dead code removal, style fixes, etc. label Jun 8, 2022
@alliepiper
Copy link
Collaborator

run tests

@alliepiper alliepiper added this to the 2.0.0 milestone Jun 22, 2022
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@alliepiper alliepiper added the testing: gpuCI passed Passed gpuCI testing. label Jun 23, 2022
@alliepiper alliepiper merged commit 105934f into NVIDIA:main Jun 29, 2022
@mfbalin mfbalin deleted the zip_function-patch branch July 27, 2022 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend: CUDA Related to the CUDA backend P1: should have Necessary, but not critical. testing: gpuCI passed Passed gpuCI testing. type: cleanup Modernization, dead code removal, style fixes, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants