Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

update type_traits/logical_metafunctions.h #1547 #1548

Merged
merged 1 commit into from
Oct 26, 2021
Merged

update type_traits/logical_metafunctions.h #1547 #1548

merged 1 commit into from
Oct 26, 2021

Conversation

PhilipDeegan
Copy link
Contributor

This is to avoid namespace conflict with termios.h definition of macro "B0"

This is to avoid namespace conflict with termios.h definition of macro "B0"
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@alliepiper
Copy link
Collaborator

DVS CL: 30574791

run tests

@alliepiper alliepiper self-assigned this Oct 25, 2021
@alliepiper alliepiper added the type: bug: functional Does not work as intended. label Oct 25, 2021
@alliepiper alliepiper added this to the 1.16.0 milestone Oct 25, 2021
@alliepiper alliepiper added testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Oct 25, 2021
@alliepiper
Copy link
Collaborator

LGTM -- I'll merge this once the tests come back. Thanks for the PR!

@alliepiper alliepiper added testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Oct 26, 2021
@alliepiper alliepiper modified the milestones: 1.16.0, 1.15.0 Oct 26, 2021
@alliepiper
Copy link
Collaborator

LGTM -- I'll backport this into the 1.15 branch before the next RC. Thanks for the fix!

@alliepiper alliepiper merged commit b8233c4 into NVIDIA:main Oct 26, 2021
@alliepiper alliepiper linked an issue Nov 12, 2021 that may be closed by this pull request
@PhilipDeegan PhilipDeegan deleted the termios_conflict branch November 12, 2021 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS). type: bug: functional Does not work as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template parameter name conflict with termios.h macro definition
3 participants