This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Update deprecation mechanism. #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
force-pushed
the
update_deprecate_impl
branch
2 times, most recently
from
27518ae to
439fd90
Compare
|
DVS CL: 30058645 run tests |
alliepiper
force-pushed
the
update_deprecate_impl
branch
from
439fd90 to
ed1898a
Compare
alliepiper
added
testing: internal ci passed
|
run tests |
alliepiper
added
testing: gpuCI passed
brycelelbach
approved these changes
Jun 14, 2021
Opt-out for our internal builds, since we'll still need to maintain and test any deprecated APIs.
alliepiper
force-pushed
the
update_deprecate_impl
branch
from
ed1898a to
506c82b
Compare
|
Last push removed CUB bump to simplify merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the deprecation mechanism to provide an opt-out, cmake options, and C++14 syntax. Our internal build will opt-out of deprecation warnings so we can continue to maintain and test deprecated APIs. This corresponds with the changes in NVIDIA/cub#320.