This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix tuple_size/tuple_element for cv-qualified types #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run tests |
|
DVS CL: 30066487 |
alliepiper
added
testing: internal ci in progress
|
@jrhemstad This is failing gpuCI tests. Can you take a look? I'm planning to cut 1.13's first RC today/tomorrow. Do you need this in 1.13 or can it wait for 1.14? |
alliepiper
removed
testing: gpuCI in progress
|
Yeah, there's a flaw with my solution. I'm working on a better one now. It doesn't matter to me which release this gets into. |
|
Sounds good. I'll move this to 1.14 so no rush. |
|
run tests |
jrhemstad
changed the title
|
@allisonvacanti is the failure for nvc++ expected? |
|
Yeah, we're in the process of updating that builder to a new nvhpc version. You can ignore it for now. |
|
@allisonvacanti this should be good to test on DVS now. |
|
DVS CL: 30144504 |
alliepiper
added
testing: gpuCI passed
alliepiper
added
testing: internal ci passed
alliepiper
approved these changes
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1456