This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix transform_iterator with non-copyable types #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the transform_iterator implementation would make a copy of the adapted iterators value when dereferencing it in order to force conversion to the value_type. This prevented transform_iterators over non-copyable types. Using a reference instead allows for forcing the conversion without invoking a copy ctor.
|
This LGTM -- thanks @jrhemstad! I'll start testing and plan to get this in for 1.13. |
|
run tests |
|
DVS CL: 29946602 |
alliepiper
added
the
testing: internal ci in progress
|
@allisonvacanti are the ICC test failures expected? They look like they are happening in scan code unrelated to my changes. |
|
Yeah, those can be ignored. |
alliepiper
added
testing: internal ci passed
alliepiper
approved these changes
May 12, 2021
There was a problem hiding this comment.
Tests look good -- I'll merge this soon. Thanks @jrhemstad!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1421
Previously, the transform_iterator implementation would make a copy
of the adapted iterators value when dereferencing it in order to
force conversion to the value_type. This prevented transform_iterators
over non-copyable types. Using a reference instead allows for forcing
the conversion without invoking a copy ctor.