Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Enable more warning flags. #1359

Merged
merged 22 commits into from
Feb 16, 2021
Merged

Enable more warning flags. #1359

merged 22 commits into from
Feb 16, 2021

Conversation

alliepiper
Copy link
Collaborator

@alliepiper alliepiper commented Dec 11, 2020 •
edited
Loading

Fixes NVIDIA/cub#228.
Fixes #1273.

Requires NVIDIA/cub#249.

@alliepiper alliepiper marked this pull request as draft December 11, 2020 02:45
@alliepiper alliepiper added this to the 1.12.0 milestone Dec 11, 2020
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from 7d6d247 to 5413017 Compare December 11, 2020 13:48
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch 2 times, most recently from 21bbf7b to e67f342 Compare December 11, 2020 21:04
@alliepiper alliepiper linked an issue Dec 11, 2020 that may be closed by this pull request
[NVBug 3129879] MSVC debug iterators give dreaded "[subobject]" nvcc execution space warnings #1273
Closed
@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from e67f342 to ef350b0 Compare December 15, 2020 21:31
brycelelbach
brycelelbach reviewed Jan 1, 2021
View reviewed changes
cmake/ThrustBuildCompilerTargets.cmake Outdated Show resolved Hide resolved
cmake/ThrustBuildCompilerTargets.cmake Show resolved Hide resolved
cmake/ThrustBuildCompilerTargets.cmake Show resolved Hide resolved
cmake/ThrustBuildCompilerTargets.cmake Outdated Show resolved Hide resolved
cmake/ThrustBuildCompilerTargets.cmake Outdated Show resolved Hide resolved
testing/functional_placeholders_bitwise.cu Show resolved Hide resolved
testing/set_symmetric_difference.cu Show resolved Hide resolved
thrust/system/cuda/detail/future.inl Show resolved Hide resolved
thrust/system/detail/generic/sequence.inl Show resolved Hide resolved
thrust/system/detail/generic/shuffle.inl Outdated
const uint64_t key) const {
uint64_t hash0 = thrust::random::taus88(value)();
const uint64_t key_) const {
uint64_t hash0 = thrust::random::taus88(static_cast<uint32_t>(value))();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be std::uint32_t and std::uint64_t?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No -- tau88 only accepts uint32_t inputs. This doesn't change anything, it just makes the implicit cast explicit and silences the conversion warnings.

I checked with the shuffle author about this change and he was fine with it, it shouldn't affect the results.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just meant stick std:: in front of the types.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from ef350b0 to b9e6052 Compare January 22, 2021 23:08
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch 2 times, most recently from 1a0ff3a to 46db957 Compare January 23, 2021 02:55
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from 46db957 to ec1df9f Compare January 25, 2021 19:40
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from ec1df9f to b3b8a67 Compare January 25, 2021 20:01
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from b3b8a67 to eab18bc Compare January 26, 2021 20:13
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper
Copy link
Collaborator Author

DVS CL: 29547313

@alliepiper alliepiper marked this pull request as ready for review January 26, 2021 21:00
@alliepiper alliepiper added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI passed Passed gpuCI testing. labels Jan 26, 2021
@alliepiper alliepiper linked an issue Jan 26, 2021 that may be closed by this pull request
Compiler warning with counting_iterator in MSVC #1091
Closed
@alliepiper alliepiper mentioned this pull request Jan 26, 2021
Closed
@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Feb 10, 2021
@alliepiper
Bump CUB for compliance / warning fixes.
2c2d288
@alliepiper
Remove stand-in macros for C++11 features and use them directly.
24c19e5 
Replaces the macros for:
- THRUST_CONSTEXPR
- THRUST_OVERRIDE
- THRUST_DEFAULT
- THRUST_NOEXCEPT
- THRUST_FINAL
@alliepiper
Add THRUST_IF_CONSTEXPR.
28fcb12 
MSVC /W4 issues warnings when this could be used but isn't.

We still have to suppress the MSVC warnings since there's no way to
silence them pre-C++17.
@alliepiper
Name unnamed structs.
b2b093e 
Anonymous structs are C features. In C++, they're non-portable
compiler extensions.

These only seemed to pop up in CUB-style `TempStorage` objects, I just
picked some reasonable sounding names for them.
@alliepiper
Ignore unreachable code warnings from testing/expected exceptions.
c3e726f 
Some tests throw exceptions unconditionally and this warning is safe
to ignore in such cases.

Added a `thrust.silence_unreachable_code_warnings` interface target to
collect various compiler flags that disable these warnings. This can be
linked selectively in a per-test `<testname>.cmake` file to only disable
warnings on the tests where this behavior is expected.
@alliepiper
Fix assorted shadowed variable warnings.
a04dccc
@alliepiper
Mark global test variable used on GCC.
754fda8
@alliepiper
Extend the partially_implemented logic to restrict by host, too.
c426f67 
The unittest_static_assert test needs to be disable for TBB/OMP hosts,
too.
@alliepiper
Fix C++17 + NVCC + MSVC + CMake.
1fe6639 
The `cuda_std_17` compile feature is broken for MSVC when
CMake < 3.18.3.
@alliepiper
Fix various numeric conversion warnings.
5d93f14
@alliepiper
Add missing private header inclusion.
33fa165
@alliepiper
Use invoke_result instead of result_of on C++17.
cdfbc82
@alliepiper
Remove dead code.
c6446db
@alliepiper
Remove unreachable code from test case.
fd87fcf
@alliepiper
Use new cub::DivideAndRoundUp util to avoid overflow errors.
8f876ba 
The expression `(n + d - 1) / d` can overflow the numerator. The
new method avoids that.

See NVIDIA/cub#221 for reference.
@alliepiper
Update shuffle.inl to use std:: type aliases instead of C versions.
20d8571 
Also removed some obsolete C++98 checks.
@alliepiper
Remove dead code.
e4380f1
@alliepiper
Refactor to avoid a static_cast in example code.
e167dce
@alliepiper
Clean up whitespace.
6ab779a
@alliepiper
Refactor out some calls to rand() in tests.
91b4b43
@alliepiper
Fix whitespace.
6b6b7f5
@alliepiper
Enable more compiler warning flags.
f3e511f 
Includes a workaround that fixes NVIDIA#1273.
@alliepiper alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from d729e2d to f3e511f Compare February 16, 2021 18:51
@alliepiper alliepiper merged commit df8afb8 into NVIDIA:main Feb 16, 2021
@alliepiper alliepiper deleted the enh/pedantic_flags/gh.cub228 branch February 16, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brycelelbach brycelelbach brycelelbach approved these changes

Assignees
No one assigned
Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.12.0
2 participants
@alliepiper @brycelelbach