This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
cross_system_copy_n: Dont attempt a copy if we're tyring to copy 0 elements #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM -- thanks for the patch! |
…ements Attempting to perform this copy with 0 elements caused a debug assertion when compiling with MSVC in debug mode. Fixes NVIDIA#1275
alliepiper
force-pushed
the
uninit_copy
branch
from
2f87ec0 to
5a2315f
Compare
|
Last push fixed a signed/unsigned comparison warning from gcc 7. |
alliepiper
added
testing: gpuCI passed
|
ok to test |
|
Can one of the admins verify this patch? |
|
run tests |
|
DVS CL: 29265527 |
alliepiper
added
the
testing: internal ci in progress
alliepiper
added
testing: internal ci passed
alliepiper
approved these changes
Nov 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to perform this copy with 0 elements caused a debug assertion when compiling with MSVC in debug mode.
Fixes #1275