This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Restore some THRUST_DECLTYPE_RETURNS macros in async test implementations #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. This partially reverts 7ff227a and fixes NVIDIA#1250. I'm not sure why changing these broke the tests, but since these usages are just testing details that are being refactored by NVIDIA#1251 let's just revert the change for now. The test failures were only happening on GCC, MSVC was fine with both versions of these functions, so it may be a compiler issue.
alliepiper
changed the title
|
DVS CL 28912962 |
alliepiper
added
the
testing: internal ci in progress
brycelelbach
approved these changes
Aug 10, 2020
alliepiper
added
testing: internal ci passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts 7ff227a and
fixes #1250.
I'm not sure why changing these broke the tests, but since these
usages are just testing details that are being refactored by #1251
let's just revert the change for now.
The test failures were only happening on GCC, MSVC was fine with both
versions of these functions, so it may be a compiler issue.