This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Use transparent functors in placeholder expressions. #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
force-pushed
the
bug/transparent_placeholder_functionals/gh.1178/gh.1229
branch
3 times, most recently
from
1de9eb0 to
38c9475
Compare
|
Is the plan to bring #1186 back after this is merged in? |
|
That commit was only reverted on a staging branch for an upcoming release, which is only taking critical bugfixes right now. #1186 is still in |
alliepiper
force-pushed
the
bug/transparent_placeholder_functionals/gh.1178/gh.1229
branch
from
38c9475 to
a4bf7f7
Compare
alliepiper
force-pushed
the
bug/transparent_placeholder_functionals/gh.1178/gh.1229
branch
from
a4bf7f7 to
ef1ad8a
Compare
|
Rebased on master, started DVS CL 28862936. |
alliepiper
added
the
testing: internal ci in progress
alliepiper
force-pushed
the
bug/transparent_placeholder_functionals/gh.1178/gh.1229
branch
2 times, most recently
from
dd12cba to
ade1934
Compare
|
Confirmed that this change doesn't significantly impact compile times. Restarted DVS on same CL after refactoring the new static assert in |
alliepiper
force-pushed
the
bug/transparent_placeholder_functionals/gh.1178/gh.1229
branch
from
ade1934 to
a2451e3
Compare
alliepiper
added
testing: internal ci passed
|
@dkolsen-pgi can you review this when you get a chance? It addresses your issue with |
dkolsen-pgi
reviewed
Aug 28, 2020
dkolsen-pgi
approved these changes
Aug 28, 2020
Fixes and adds regression tests for NVIDIA#1178 & NVIDIA#1229.
alliepiper
force-pushed
the
bug/transparent_placeholder_functionals/gh.1178/gh.1229
branch
from
a2451e3 to
aa6dc83
Compare
|
rebased and addressed review feedback. |
alliepiper
deleted the
bug/transparent_placeholder_functionals/gh.1178/gh.1229
branch
This was referenced Aug 28, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and adds regression tests for #1178 & #1229.