This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Make out_of_memory_recovery test trigger OOM faster. #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#1183. This test is taking up the majority of the test runtime on CPU backends, slowing eating away at RAM/swap for two minutes while the rest of the system gets evicted from RAM and stops responding. Replaced the allocation loop with a single large allocation, now the test runs in ~1ms and doesn't actually allocate significant resources.
|
CL 28522192. |
alliepiper
added
the
testing: internal ci in progress
brycelelbach
approved these changes
Jun 10, 2020
| // | ||
| // Summary of 2720132: | ||
| // | ||
| // 1. The large allocation fails due to running out of memory. |
There was a problem hiding this comment.
0 index your lists!
There was a problem hiding this comment.
You first! :)
alliepiper
added
testing: gpuCI passed
|
A full multiconfig test cycle is now 45 minutes shorter 🎉 🎉 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1183. This test is taking up the majority of the test
runtime on CPU backends, slowing eating away at RAM/swap for
two minutes while the rest of the system gets evicted from RAM
and stops responding.
Replaced the allocation loop with a single large allocation,
now the test runs in ~1ms and doesn't actually allocate
significant resources.