This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Avoid returning uninitialized allocator #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitted to internal CI. @griwes to review. |
brycelelbach
previously requested changes
Oct 28, 2019
|
Failed internal CI; this change depends on C++11 in a part of Thrust that is not C++11 only. |
zhihaoy
force-pushed
the
fix_uninitialized_allocator
branch
from
3c90b30 to
61df1d1
Compare
|
I can take over landing this, @brycelelbach @griwes, unless either of you wants more changes. |
alliepiper
force-pushed
the
fix_uninitialized_allocator
branch
from
61df1d1 to
5964e5e
Compare
|
Started internal CI: 28483956 |
alliepiper
added
the
testing: internal ci in progress
|
Tests passed -- I'll merge this in my next round of integrations. Thanks for the patch! |
alliepiper
added
testing: internal ci passed
alliepiper
approved these changes
Jun 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caught by MSVC Debug build. There is no customized allocators being used, just host_vector and device_vector.