-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy_if integer overflow for sizes > 2^31 #747
Labels
thrust
For all items related to Thrust.
Comments
We should triage this by using |
Related to #744. |
I am seeing a similar issue with |
3 tasks
rapids-bot bot
referenced
this issue
in rapidsai/cudf
Nov 10, 2022
Workaround for limitation in `thrust::copy_if` which fails if the input-iterator spans more than int-max. The `thrust::copy_if` hardcodes the iterator distance type to be an int https://github.com/NVIDIA/thrust/blob/dbd144ed543b60c4ff9d456edd19869e82fe8873/thrust/system/cuda/detail/copy_if.h#L699-L708 Found existing thrust issue: https://github.com/NVIDIA/thrust/issues/1302 This calls the `copy_if` in chunks if the iterator can span greater than int-max. Closes #12058 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Alessandro Bellina (https://github.com/abellina) - Robert Maynard (https://github.com/robertmaynard) - Nghia Truong (https://github.com/ttnghia) URL: #12079
This was referenced Nov 16, 2022
rapids-bot bot
referenced
this issue
in rapidsai/cudf
Nov 28, 2022
Workaround in nvtext's wordpiece-tokenizer due to limitation in `thrust::copy_if` which fails if the input-iterator spans more than int-max. Found existing thrust issue: https://github.com/NVIDIA/thrust/issues/1302 This calls the `thrust::copy_if` in chunks if the iterator can span greater than int-max. Found while working on #12079 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - Vyas Ramasubramani (https://github.com/vyasr) URL: #12168
rapids-bot bot
referenced
this issue
in rapidsai/cudf
Dec 6, 2022
Workaround in json's get_tree_representation due to limitation in `thrust::copy_if` which fails if the input-iterator spans more than int-max. Found existing thrust issue: https://github.com/NVIDIA/thrust/issues/1302 This calls the thrust::copy_if in chunks if the iterator can span greater than int-max. Found while working on #12079 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Elias Stehle (https://github.com/elstehle) - Mike Wilson (https://github.com/hyperbolic2346) URL: #12190
Closing in favor of #744 |
2 tasks
We have just merged PR #1379 that addresses this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For sizes > 2^31 we get an integer overflow with copy_if using the device backend. This results in out of memory:
MRE:
Suspected cause:
https://github.com/NVIDIA/thrust/blob/e4d96a2ecaae1fb2964be8caace289e3c314ac7b/thrust/system/cuda/detail/copy_if.h#L704
Custom cub-like backend, still using int size type.
The text was updated successfully, but these errors were encountered: