Fix invalid parameter issue when force to close endpoint #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petro-rudenko could you help to review the code change? Thanks. |
| @@ -188,7 +188,14 @@ case class UcxWorkerWrapper(worker: UcpWorker, transport: UcxShuffleTransport, i | |||
| def connectByWorkerAddress(executorId: transport.ExecutorId, workerAddress: ByteBuffer): Unit = { | |||
| logDebug(s"Worker $this connecting back to $executorId by worker address") | |||
| val ep = worker.newEndpoint(new UcpEndpointParams().setName(s"Server connection to $executorId") | |||
| .setUcpAddress(workerAddress)) | |||
| .setUcpAddress(workerAddress) | |||
| .setPeerErrorHandlingMode() | |||
There was a problem hiding this comment.
@yosefe does peerErrorHandling mode works with connect by worker address?
There was a problem hiding this comment.
In UCX,
ucs_status_ptr_t ucp_ep_close_nbx(ucp_ep_h ep, const ucp_request_param_t *param)
{
ucp_worker_h worker = ep->worker;
void *request = NULL;
ucp_request_t *close_req;
if ((ucp_request_param_flags(param) & UCP_EP_CLOSE_FLAG_FORCE) &&
(ucp_ep_config(ep)->key.err_mode != UCP_ERR_HANDLING_MODE_PEER)) {
return UCS_STATUS_PTR(UCS_ERR_INVALID_PARAM);
}
when force to close the ep, it will also check the flag UCP_ERR_HANDLING_MODE_PEER setting.
|
Can you please sign your commit |
Signed-off-by: Brian Sheng <[email protected]>
brianplus
force-pushed
the
dev/brian/closeNonBlockingForce_invalid_parameter
branch
from
31ac160
to
4cdaece
Compare
jeynmann
referenced
this pull request
in jeynmann/sparkucx
Mar 17, 2023
Signed-off-by: Brian Sheng <[email protected]>
|
Signed. Thanks Peter. |
petro-rudenko
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix invalid parameter exception when force to close endpoint.
Why ?
When
UcxWorkerWrapperforces close the endpoints, it will hitorg.openucx.jucx.UcxException: Invalid parameterissue. It's because in UCX native code,ucp_ep_close_nbx, whenUCP_EP_CLOSE_FLAG_FORCEis set,UCP_ERR_HANDLING_MODE_PEERalso has to be set to key's err_mode.How ?
Call
setPeerErrorHandlingModeto setUCP_ERR_HANDLING_MODE_PEERwhen create endpoint connection and callsetErrorHandlerto set error handling code as well.