-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support split BroadcastNestedLoopJoin condition for AST and non-AST [databricks] #9702
Conversation
…ange Signed-off-by: Jason Lowe <[email protected]>
Signed-off-by: Ferdinand Xu <[email protected]>
…NVIDIA#9635) Signed-off-by: Ferdinand Xu <[email protected]>
build |
@jlowe could you also take a look at the fix for databricks? |
...in/spark311/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastNestedLoopJoinExec.scala
Outdated
Show resolved
Hide resolved
...in/spark311/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastNestedLoopJoinExec.scala
Outdated
Show resolved
Hide resolved
.../spark330db/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastNestedLoopJoinExec.scala
Show resolved
Hide resolved
build |
It seems to fail due to irrelevant cases. For HYPOT function, is it acceptable to have some diff against CPU? It's different at 0.000 000 000 000 001e-123 against CPU @NVnavkumar Error log
|
build |
I think this is okay, but we should file an issue for it. It is likely caused by I'll file the issue. |
I filed #9744 for this and I'll put up a PR to mark it as xfail shortly. |
This is to fix #8832 and #9681. This PR is based on #9635 while fixing issues in databrick runtime.