Enable build for Databricks 13.3 [databricks] #9677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replace_table_as_select
gerashegalov
requested changes
Nov 12, 2023
Signed-off-by: Raza Jafri <[email protected]>
jlowe
reviewed
Nov 13, 2023
|
build |
|
Latest failure is in fastparquet compatibility test which I could not reproduce on a Databricks 13.3 instance. Kicking again to see if it's reproducible. |
|
build |
|
I'm now able to reproduce the fastparquet failures, and it appears to be an issue with the fastparquet setup on Databricks 13.3. It's reading NaNs as nulls, whereas the GPU is reading NaNs as NaNs. Not sure yet why we're getting different fastparquet behavior in the DB 13.3 environment with an explicit install of fastparquet vs. what we get on the other Databricks environments. |
|
build |
1 similar comment
|
build |
|
build |
1 similar comment
|
build |
|
341db failed deltalake cases |
|
build |
revans2
approved these changes
Nov 21, 2023
|
build |
mythrocks
reviewed
Nov 22, 2023
Comment on lines
+110
to
+112
| pytest.param(FloatGen(nullable=False), | ||
| marks=pytest.mark.xfail(is_databricks_runtime(), | ||
| reason="https://github.com/NVIDIA/spark-rapids/issues/9778")), |
There was a problem hiding this comment.
I was thinking of including the following:
Suggested change
| pytest.param(FloatGen(nullable=False), | |
| marks=pytest.mark.xfail(is_databricks_runtime(), | |
| reason="https://github.com/NVIDIA/spark-rapids/issues/9778")), | |
| pytest.param(FloatGen(nullable=False), | |
| marks=pytest.mark.xfail(is_databricks_runtime(), | |
| reason="https://github.com/NVIDIA/spark-rapids/issues/9778")), | |
| FloatGen(nullable=False, no_nans=True), |
Not strictly in the purview of this change. I can add this as a follow-on.
mythrocks
approved these changes
Nov 22, 2023
|
build |
1 similar comment
|
build |
|
thanks! also cc @NvTimLiu to help setup nightly later, thanks |
|
Thanks for merging, @pxLi. I built three times to make sure CI would not be flaky with heap GC OOM or other problems, passed three times in a row. So we should be good with this enabled for premerge and nightly. |
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on previous PRs to add Databricks 13 support to the Spark Rapids plugin. This PR specifically adds pom changes to build the plugin with Databricks 13.3.
Changes Made:
POM changes: All the modules have been updated with a profile for 341db support
XFAIL failing tests: Tests were marked with xfail pytest marker which should be removed once the support is added for them.
PythonUDAF: Added support for PythonUDAF similar to Spark 3.5
Tests:
All the tests were updated
This is in draft mode because it should be merged only after #9644 is merged