Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonRunner and RapidsErrorUtils Changes For Databricks 13.3 #9593

Merged
merged 15 commits into from
Nov 3, 2023

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Oct 31, 2023

This PR includes changes to handle Databricks 13.3 changes for the PythonRunner and QueryExecutionErrors.

Contributes to #9175

Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a number of files in this PR that seem completely unrelated to PythonRunner changes, e.g.:

  • PartitionedFileUtilsShim
  • GpuShuffleExchangeExec
  • ParquetCVShims
  • FilePartitionShims
  • FileSinkDescShim
  • HiveInspectorsShim
  • GpuBroadcastHashJoinExec
  • GpuBroadcastNestedLoopJoinExec

Signed-off-by: Raza Jafri <[email protected]>
@razajafri razajafri changed the title PythonRunner Changes For Databricks 13.3 PythonRunner and RapidsErrorUtils Changes For Databricks 13.3 Nov 1, 2023
@razajafri razajafri marked this pull request as ready for review November 1, 2023 11:07
@sameerz sameerz added the task Work required that improves the product but is not user facing label Nov 1, 2023
@razajafri razajafri requested a review from jlowe November 1, 2023 13:10
jlowe
jlowe previously approved these changes Nov 1, 2023
@jlowe
Copy link
Contributor

jlowe commented Nov 1, 2023

build

@jlowe
Copy link
Contributor

jlowe commented Nov 1, 2023

CI failed due to compile errors for 321db

@razajafri
Copy link
Collaborator Author

build

@jlowe
Copy link
Contributor

jlowe commented Nov 2, 2023

CI is failing in a related test:

[2023-11-02T07:33:57.890Z] FAILED ../../src/main/python/udf_test.py::test_map_pandas_udf_with_empty_partitions[INJECT_OOM] - AssertionError: CPU and GPU list have different lengths at [] CPU: 5 GPU: 1

@razajafri
Copy link
Collaborator Author

CI is failing in a related test:

[2023-11-02T07:33:57.890Z] FAILED ../../src/main/python/udf_test.py::test_map_pandas_udf_with_empty_partitions[INJECT_OOM] - AssertionError: CPU and GPU list have different lengths at [] CPU: 5 GPU: 1

I missed a change from another PR

@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri requested a review from jlowe November 2, 2023 16:17
@razajafri razajafri merged commit 54145c4 into NVIDIA:branch-23.12 Nov 3, 2023
36 checks passed
@razajafri razajafri deleted the db13.3-new branch November 3, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants