Fix test_window_running*() for NTH_VALUE IGNORE NULLS.
#9575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#9569. NVIDIA#9489 added `NTH_VALUE()` tests with option to `IGNORE NULLS`, but mistakenly enabled `IGNORE NULLS` for Spark versions prior to `3.2.1`. This commit restricts tests for `IGNORE NULLS` to only Spark versions exceeding `3.1.x`, where the feature is available. Signed-off-by: MithunR <[email protected]>
mythrocks
force-pushed
the
batched-window-first-tests
branch
from
eb08d4b to
043938a
Compare
|
Build |
revans2
approved these changes
Oct 30, 2023
pxLi
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9569.
#9489 added
NTH_VALUE()tests with option toIGNORE NULLS, but mistakenly enabledIGNORE NULLSfor Spark versions prior to3.2.1.This commit restricts tests for
IGNORE NULLSto only Spark versions exceeding3.1.x, where the feature is available.