Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a two-shim jar by default on Databricks [databricks] #9013

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Create a two-shim jar by default on Databricks [databricks] #9013

merged 5 commits into from
Aug 11, 2023

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Aug 11, 2023 •
edited
Loading

@gerashegalov gerashegalov self-assigned this Aug 11, 2023
@gerashegalov gerashegalov added the build Related to CI / CD or cleanly building label Aug 11, 2023
@gerashegalov gerashegalov changed the title Create a two-shim jar by default on Databricks Create a two-shim jar by default on Databricks [databricks] Aug 11, 2023
@gerashegalov gerashegalov requested a review from tgravescs August 11, 2023 18:00
@gerashegalov gerashegalov added the test Only impacts tests label Aug 11, 2023
@gerashegalov
Copy link
Collaborator Author

build

1 similar comment
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov linked an issue Aug 11, 2023 that may be closed by this pull request
[FEA] Make databricks CI pipeline use a multi-shim jar. #9008
Closed
jlowe
jlowe previously approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK to me, but wondering if we want to target 23.08 for this given how close we are to release.

razajafri
razajafri reviewed Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but I have the same comment as @jlowe why are we targeting 23.08?

@gerashegalov
Copy link
Collaborator Author

gerashegalov commented Aug 11, 2023 •
edited
Loading

I share the concern re: 23.08. I am torn only because I am afraid that we might still need to make changes to 23.08 that will not receive this testing until nightly. FWIW I already see the change is successfully exercised by the CI.

@razajafri razajafri mentioned this pull request Aug 11, 2023
Merged
@gerashegalov gerashegalov changed the base branch from branch-23.08 to branch-23.10 August 11, 2023 20:01
@gerashegalov gerashegalov dismissed jlowe’s stale review August 11, 2023 20:01

The base branch was changed.

@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov merged commit eb35134 into NVIDIA:branch-23.10 Aug 11, 2023
@gerashegalov gerashegalov deleted the dbBuild2Shims branch August 11, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razajafri razajafri razajafri approved these changes

@jlowe jlowe jlowe approved these changes

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@zhanga5 zhanga5 Awaiting requested review from zhanga5

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

Assignees

@gerashegalov gerashegalov

Labels
build Related to CI / CD or cleanly building test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Make databricks CI pipeline use a multi-shim jar.
4 participants
@gerashegalov @jlowe @tgravescs @razajafri