Experimental support for BloomFilterAggregate expression in a reduction context [databricks] #8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
Signed-off-by: Jason Lowe <[email protected]>
|
build |
abellina
previously approved these changes
Aug 2, 2023
|
build |
2 similar comments
|
build |
|
build |
abellina
reviewed
Aug 4, 2023
tests/src/test/spark330/scala/com/nvidia/spark/rapids/BloomFilterAggregateQuerySuite.scala
Outdated
Show resolved
Hide resolved
tests/src/test/spark330/scala/com/nvidia/spark/rapids/BloomFilterAggregateQuerySuite.scala
Outdated
Show resolved
Hide resolved
abellina
previously approved these changes
Aug 4, 2023
|
build |
|
Converting to draft as it needs the fixes from #8944 and the need to upmerge to the new tests there. |
revans2
reviewed
Aug 8, 2023
| (ReductionAggExprContext, | ||
| ContextChecks(TypeSig.BINARY, TypeSig.BINARY, | ||
| Seq(ParamCheck("child", TypeSig.LONG, TypeSig.LONG), | ||
| ParamCheck("estimatedItems", TypeSig.lit(TypeEnum.LONG), TypeSig.LONG), |
There was a problem hiding this comment.
nit: Technically Spark is also checking to be sure that estimatedItems and estimatedBits are literals, actually foldable and > 0 and <= the config. So we could mark those as lit too and then the docs just show that we fully support it instead of adding a comment that we do not.
jlowe
changed the title
|
build |
|
build |
revans2
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #7803. Depends on #8775. Closes #8955.
Implements GPU support for BloomFilterAggregate in a reduction context. This is used by Bloom filter optimized joins which are available in Spark 3.3.0 and enabled by default in Spark 3.4.0.