Handle TIMESTAMP_MILLIS for rebase check #8687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
|
build |
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
|
I realized that I misunderstood the meaning of note in this issue. Now, I split scanAndWrite into scan and write and check if rebase is needed before type casting. |
|
build |
thirtiseven
changed the title
abellina
reviewed
Jul 11, 2023
revans2
reviewed
Jul 11, 2023
revans2
approved these changes
Jul 12, 2023
|
build |
abellina
approved these changes
Jul 12, 2023
|
I am merging this because I'd like to pull the changed into another PR I have up that is also ready to go in fairly soon after this. Thanks @thirtiseven ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1130
We aren't properly handling spark.sql.legacy.parquet.datetimeRebaseModeInWrite=TIMESTAMP_MILLIS in isDateTimeRebaseNeeded when we run with spark.sql.parquet.outputTimestampType=EXCEPTION. It should throw a SparkUpgradeException in this case.
This PR updated the
ColumnarOutputWriterto scan the table beforetransform. So in the issue's case, rebase check will happen before type casting. Now the plugin will handle TIMESTAMP_MILLIS normally and throw SparkUpgradeException in the issue's case.