Add retry to BatchByKeyIterator #8058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
abellina
previously approved these changes
Apr 7, 2023
| spillableBuffers.append(pending.dequeue()) | ||
| } | ||
| pendingSize = 0 | ||
| last.foreach { lastSpill => |
There was a problem hiding this comment.
nit, could be replaced with: spillableBuffers.appendAll(last). I didn't know that you could, but it looks like appendAll can handle an Option and if set to None it is a noop.
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuKeyBatchingIterator.scala
Show resolved
Hide resolved
|
build |
sameerz
added
the
reliability
|
@abellina could you take another look? |
abellina
previously approved these changes
Apr 13, 2023
|
build |
|
@abellina could you look at this again. I had to upmerge |
abellina
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7778
It also fixes a bug in closeOnExcept where scala can throw an exception for flow control which in my case resulted in a use after free error for an intermediate version of the patch.