Support hashing different types for sub-partitioning #7937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An integer and byte will produce different hash values even they have the same value, but we want the same hash for them. So switch to the Plugin way to partition batches. Signed-off-by: Liangcai Li <[email protected]>
Signed-off-by: Liangcai Li <[email protected]>
Signed-off-by: Firestarman <[email protected]>
7 tasks
|
build |
jlowe
approved these changes
Mar 27, 2023
abellina
approved these changes
Mar 27, 2023
revans2
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to rapidsai/cudf#13000
This PR changes to leverage the Plugin way to partition batches instead of the cudf
hashPartitionin sub-partitioning.Because the left and right join keys with the same value but different integral types(e.g.
100.toIntand100.toByte) will produce different hash values by cudfhashPartition, breaking the join by sub-partitioning algorithm.