Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore hash aggregate tests after cub segmented sort fix [databricks] #7142

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Restore hash aggregate tests after cub segmented sort fix [databricks] #7142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
578db6c
Revert "Skip test_hash_groupby_collect_with_single_distinct (#7107)"
jlowe Nov 22, 2022
f8f1d2c
Revert "Skip test_hash_groupby_collect_partial_replace_with_distinct_…
jlowe Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions integration_tests/src/main/python/hash_aggregate_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,6 @@ def do_it(spark):

@ignore_order(local=True)
@pytest.mark.parametrize('data_gen', _full_gen_data_for_collect_op, ids=idfn)
@pytest.mark.skip(reason='https://github.com/NVIDIA/spark-rapids/issues/7092,7104')
def test_hash_groupby_collect_with_single_distinct(data_gen):
# test collect_ops with other distinct aggregations
assert_gpu_and_cpu_are_equal_collect(
Expand Down Expand Up @@ -840,7 +839,6 @@ def test_hash_groupby_collect_partial_replace_fallback(data_gen,
@pytest.mark.parametrize('aqe_enabled', ['false', 'true'], ids=idfn)
@pytest.mark.parametrize('use_obj_hash_agg', ['false', 'true'], ids=idfn)
@pytest.mark.xfail(condition=is_databricks104_or_later(), reason='https://github.com/NVIDIA/spark-rapids/issues/4963')
@pytest.mark.skip(reason='https://github.com/NVIDIA/spark-rapids/issues/7092')
def test_hash_groupby_collect_partial_replace_with_distinct_fallback(data_gen,
replace_mode,
aqe_enabled,
Expand Down