-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks] #7102
Merged
pxLi
merged 5 commits into
NVIDIA:branch-22.12
from
pxLi:lower-premerge-parallelism-to-2
Nov 18, 2022
Merged
Skip test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks] #7102
pxLi
merged 5 commits into
NVIDIA:branch-22.12
from
pxLi:lower-premerge-parallelism-to-2
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <[email protected]>
pxLi
added
bug
Something isn't working
build
Related to CI / CD or cleanly building
labels
Nov 18, 2022
pxLi
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
November 18, 2022 01:04
build |
This reverts commit c67927b.
Signed-off-by: Peixin Li <[email protected]>
pxLi
changed the title
Temporarily lower parallelism for #7092 [databricks]
Xfail test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks]
Nov 18, 2022
build |
pxLi
changed the title
Xfail test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks]
Skip test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks]
Nov 18, 2022
the case could also hanging there and timeout the test, xfail does not workaround in this case |
build |
gerashegalov
previously approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Peixin Li <[email protected]>
also found new case error when run premerge filed #7104 to xfail first |
build |
zhanga5
approved these changes
Nov 18, 2022
jlowe
added a commit
to jlowe/spark-rapids
that referenced
this pull request
Nov 22, 2022
…fallback for NVIDIA#7092 [databricks] (NVIDIA#7102)" This reverts commit c70bcfb. Signed-off-by: Jason Lowe <[email protected]>
pxLi
pushed a commit
that referenced
this pull request
Nov 23, 2022
#7142) * Revert "Skip test_hash_groupby_collect_with_single_distinct (#7107)" This reverts commit d5ba2e2. Signed-off-by: Jason Lowe <[email protected]> * Revert "Skip test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks] (#7102)" This reverts commit c70bcfb. Signed-off-by: Jason Lowe <[email protected]> Signed-off-by: Jason Lowe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li [email protected]
workaround for #7092
lower the parallelism while we are still investigating the issueturns out test_hash_groupby_collect_partial_replace_with_distinct_fallback is the case that actually fail the executor, skip for now.
also found new string_test error and filed #7104 to xfail for now