Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks] #7102

Merged
merged 5 commits into from
Nov 18, 2022

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Nov 18, 2022

Signed-off-by: Peixin Li [email protected]

workaround for #7092

lower the parallelism while we are still investigating the issue
turns out test_hash_groupby_collect_partial_replace_with_distinct_fallback is the case that actually fail the executor, skip for now.

also found new string_test error and filed #7104 to xfail for now

@pxLi pxLi added bug Something isn't working build Related to CI / CD or cleanly building labels Nov 18, 2022
@pxLi
Copy link
Collaborator Author

pxLi commented Nov 18, 2022

build

@pxLi pxLi changed the title Temporarily lower parallelism for #7092 [databricks] Xfail test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks] Nov 18, 2022
@pxLi
Copy link
Collaborator Author

pxLi commented Nov 18, 2022

build

@pxLi pxLi changed the title Xfail test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks] Skip test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks] Nov 18, 2022
@pxLi
Copy link
Collaborator Author

pxLi commented Nov 18, 2022

the case could also hanging there and timeout the test, xfail does not workaround in this case
lets skip the test for now

@pxLi
Copy link
Collaborator Author

pxLi commented Nov 18, 2022

build

gerashegalov
gerashegalov previously approved these changes Nov 18, 2022
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Peixin Li <[email protected]>
@pxLi
Copy link
Collaborator Author

pxLi commented Nov 18, 2022

also found new case error when run premerge filed #7104 to xfail first

@pxLi
Copy link
Collaborator Author

pxLi commented Nov 18, 2022

build

@pxLi pxLi merged commit c70bcfb into NVIDIA:branch-22.12 Nov 18, 2022
jlowe added a commit to jlowe/spark-rapids that referenced this pull request Nov 22, 2022
…fallback for NVIDIA#7092 [databricks] (NVIDIA#7102)"

This reverts commit c70bcfb.

Signed-off-by: Jason Lowe <[email protected]>
pxLi pushed a commit that referenced this pull request Nov 23, 2022
#7142)

* Revert "Skip test_hash_groupby_collect_with_single_distinct (#7107)"

This reverts commit d5ba2e2.

Signed-off-by: Jason Lowe <[email protected]>

* Revert "Skip test_hash_groupby_collect_partial_replace_with_distinct_fallback for #7092 [databricks] (#7102)"

This reverts commit c70bcfb.

Signed-off-by: Jason Lowe <[email protected]>

Signed-off-by: Jason Lowe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants