Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Spark 340 build error related to checkForNumericExpr #6905

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Fix Spark 340 build error related to checkForNumericExpr #6905

merged 2 commits into from
Oct 26, 2022

Conversation

HaoYang670
Copy link
Collaborator

@HaoYang670 HaoYang670 commented Oct 25, 2022 •
edited
Loading

Signed-off-by: remzi [email protected]
Close #6900.

Changes in the PR

Reimplement checkForNumericExpr in the shim layer because this function has been removed since spark 3.4.0.

branch 22.12

...
[ERROR] [Error] /home/remziy/working/rapids/spark-rapids/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala:1084: value checkForNumericExpr is not a member of object org.apache.spark.sql.catalyst.util.TypeUtils
[ERROR] [Error] /home/remziy/working/rapids/spark-rapids/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala:1575: value checkForNumericExpr is not a member of object org.apache.spark.sql.catalyst.util.TypeUtils
[ERROR] 28 errors found

this patch

...
[ERROR] 26 errors found

@HaoYang670
Copy link
Collaborator Author

build

@HaoYang670
Copy link
Collaborator Author

Hi @nartal1 , this PR doesn't fix the GetMapValue error which you mention in #6900, because we will fix that error in #6383

@nartal1 nartal1 added the build Related to CI / CD or cleanly building label Oct 25, 2022
@nartal1 nartal1 merged commit 797e02c into NVIDIA:branch-22.12 Oct 26, 2022
@HaoYang670 HaoYang670 deleted the 6900_fix_spark340_build_error branch October 28, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartal1 nartal1 nartal1 approved these changes

@tgravescs tgravescs tgravescs approved these changes

Assignees

@HaoYang670 HaoYang670

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spark-3.4 build failure in AggregateFunctions
3 participants
@HaoYang670 @tgravescs @nartal1