-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in neverReplaceExec and several rules for it #660
Conversation
Signed-off-by: Robert (Bobby) Evans <[email protected]>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's much nicer. LGTM.
Curious, I expected to see some deletes in configs.md as part of this. Did we miss the configs.md changes from the previous PR somehow? |
Yup if there had been there I would not have approved it, but they showed up afterward for me as a part of another build, so I thought why not fix it and also knock out #499 too while I was at it. |
We probably need a CI check for docs being modified during the build (maybe any checked out file being modified?), indicating PR should have included some changes that are missing. I'll file an issue. |
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Signed-off-by: Peixin Li <[email protected]> Signed-off-by: Peixin Li <[email protected]>
This extends the great work done in #647 but fixes an issue there where we were still outputting config documentation for execs we never plan to replace.
I also made adding one of these in simpler and more common. I then added in rules for all of the other commands we currently don't want to warn about or ever replace.
This fixes #499