Revert "Enable Strings as a supported type for GpuColumnarToRow transitions" #6367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itions (NVIDIA#5998)" This reverts commit 452e7ba. Signed-off-by: Jason Lowe <[email protected]>
|
build |
This was referenced Aug 19, 2022
amahussein
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
LGTM
I reopened the previous issues
- [FEA] Enable Strings as a supported type for GpuColumnarToRow transitions #5633,
- [FEA] Update CudfUnsafeRow to include size estimates for strings and implementation for getUTF8String #5634,
- [FEA] Update AcceleratedColumnarToRowIterator to support strings #5635,
- [FEA] Update GeneratedInternalRowToCudfRowIterator for string transitions #5636
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6364. Reverting #5998 as it is causing data corruption in some cases.
This reverts commit 452e7ba.
Signed-off-by: Jason Lowe [email protected]