Fix parquet binary reads to do the transformation in the plugin [databricks] #6292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
revans2
added
bug
|
build |
jlowe
reviewed
Aug 11, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/ParquetSchemaUtils.scala
Outdated
Show resolved
Hide resolved
|
build |
|
@jlowe please take another look |
jlowe
approved these changes
Aug 11, 2022
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From testing we found a number of issues with nested types and reading binary data. There were bugs in the cudf code, even with the API that made this unworkable in the short term. So this has all of the transformation to binary from string happen in the plugin instead of doing it in CUDF. Hopefully in 22.10 when the CUDF code + API is fixed we can switch over to using it and it will be cleaner and more efficient.
This replaces #6283.
This fixes #6281