Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable null in regex character classes #5976

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Enable null in regex character classes #5976

merged 4 commits into from
Jul 11, 2022

Conversation

anthony-chang
Copy link
Contributor

Closes #5909

Enable the null terminator \u0000 in character classes, character class ranges, and in the POSIX predefined character classes.

@anthony-chang anthony-chang self-assigned this Jul 8, 2022
@sameerz sameerz added the feature request New feature or request label Jul 8, 2022
@anthony-chang
Use the right toString function
d2ac8d7 
Signed-off-by: Anthony Chang <[email protected]>
@anthony-chang anthony-chang requested a review from NVnavkumar July 8, 2022 22:32
@NVnavkumar
Copy link
Collaborator

build

NVnavkumar
NVnavkumar approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@NVnavkumar NVnavkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthony-chang anthony-chang merged commit 247d296 into NVIDIA:branch-22.08 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NVnavkumar NVnavkumar NVnavkumar approved these changes

Assignees

@anthony-chang anthony-chang

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Null characters do not work in regular expression character classes
3 participants
@anthony-chang @NVnavkumar @sameerz