-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testing parquet with zstd for spark releases 3.2.0 and later #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Brennan <[email protected]>
I have verified this with spark-3.1.3, spark-3.2.0, and spark-3.2.1. |
build |
jlowe
approved these changes
Jun 23, 2022
I'm not sure what failed here. @tgravescs should I rerun tests? |
It failed in the Scala unit tests:
Looks like there's a unit test that may have a leak in it somewhere. Does not appear to be related to this PR, since it doesn't modify the unit tests. |
build |
tgravescs
changed the title
Enable testing zstd for spark releases 3.2.0 and later
Enable testing parquet with zstd for spark releases 3.2.0 and later
Jun 24, 2022
tgravescs
approved these changes
Jun 24, 2022
jbrennan333
added a commit
to jbrennan333/spark-rapids
that referenced
this pull request
Jun 27, 2022
…A#5898)" This reverts commit 321f9b9. Signed-off-by: Jim Brennan <[email protected]>
jbrennan333
added a commit
that referenced
this pull request
Jun 27, 2022
This reverts commit 321f9b9. Signed-off-by: Jim Brennan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Brennan [email protected]
Closes #5580
Spark releases starting with 3.2.0 include support for zstd compression without requiring any additional jars/libs. Now that we have zstd decompression support in cuDF, we should add zstd to the list of compressors to use in
test_parquet_compress_read_round_trip
.