-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiling tool add wholestagecodegen to execs mapping, sql to stage info and job end time #5868
Merged
tgravescs
merged 22 commits into
NVIDIA:branch-22.08
from
tgravescs:profileJobEndWholeStage
Jun 21, 2022
Merged
Profiling tool add wholestagecodegen to execs mapping, sql to stage info and job end time #5868
tgravescs
merged 22 commits into
NVIDIA:branch-22.08
from
tgravescs:profileJobEndWholeStage
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <[email protected]>
build |
1 similar comment
build |
nartal1
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5515
We add more information to the profiling tool for multiple things:
These features were requested to be able to do some post processing on the profile logs to gather more insight into which execs are taking longest and what types of speedup between cpu and gpu runs. For this is needs to map wholestagecodegen into the node types and try to determine how much time each node is taking to compare to the gpu nodes.
New tables look like: