Explicitly disable AQE in one test #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
force-pushed
the
GpuCoalesceBatchesSuite-aqe
branch
from
a75b427 to
42d114a
Compare
Signed-off-by: Andy Grove <[email protected]>
andygrove
force-pushed
the
GpuCoalesceBatchesSuite-aqe
branch
from
0b02e7c to
7c21235
Compare
|
This closes #454 |
jlowe
approved these changes
Aug 17, 2020
|
build |
pxLi
added a commit
to pxLi/spark-rapids
that referenced
this pull request
Aug 24, 2020
* explicitly disable AQE in one test (NVIDIA#567) Signed-off-by: Andy Grove <[email protected]> * Enable using spark-submit to convert from csv to parquet (NVIDIA#565) Signed-off-by: Andy Grove <[email protected]> * xfail the Spark 3.1.0 integration tests that fail (NVIDIA#580) * xfail GpuTimeSub, arithmetic ops, and full outer join failures on 3.1.0 Signed-off-by: Thomas Graves <[email protected]> * xfail the rest of the 3.1.0 tests and enable 3.1.0 unit tests in the jenkins builds Signed-off-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]> * Fix unit tests when AQE is enabled (NVIDIA#558) * Fix scala tests when AQE is enabled Signed-off-by: Niranjan Artal <[email protected]> * fix broadcasthashjoin tests Signed-off-by: Niranjan Artal <[email protected]> * fix indentation Signed-off-by: Niranjan Artal <[email protected]> * addressed review comments Signed-off-by: Niranjan Artal <[email protected]> * addressed review comments Signed-off-by: Niranjan Artal <[email protected]> * addressed review comments Signed-off-by: Niranjan Artal <[email protected]> * Update buffer store to return compressed batches directly, add compression NVTX ranges (NVIDIA#572) * Update buffer store to return compressed batches directly, add compression NVTX ranges Signed-off-by: Jason Lowe <[email protected]> * Update parameter name for clarity Signed-off-by: Jason Lowe <[email protected]> * xfail the tpch spark 3.1.0 tests that fail (NVIDIA#588) Signed-off-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]> * Move GpuParquetScan/GpuOrcScan into Shim (NVIDIA#590) * Move GpuParquetScan to shim Signed-off-by: Thomas Graves <[email protected]> * Move scan overrides into shim Signed-off-by: Thomas Graves <[email protected]> * Rename GpuParquetScan object to match Signed-off-by: Thomas Graves <[email protected]> * Add tests for v2 datasources Signed-off-by: Thomas Graves <[email protected]> * Move OrcScan into shims Signed-off-by: Thomas Graves <[email protected]> * Fixes Signed-off-by: Thomas Graves <[email protected]> * Fix imports Signed-off-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]> * Filter nulls from joins where possible to improve performance. (NVIDIA#594) * Filter nulls from joins where possible to improve performance. Signed-off-by: Robert (Bobby) Evans <[email protected]> * Addressed review comments Signed-off-by: Robert (Bobby) Evans <[email protected]> * Updated patch for other shims * changelog generator Signed-off-by: Peixin Li <[email protected]> * only filter out labels for issue * add nightly workflow on github actions Co-authored-by: Andy Grove <[email protected]> Co-authored-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]> Co-authored-by: Niranjan Artal <[email protected]> Co-authored-by: Jason Lowe <[email protected]> Co-authored-by: Robert (Bobby) Evans <[email protected]>
pxLi
added a commit
to pxLi/spark-rapids
that referenced
this pull request
Aug 24, 2020
* explicitly disable AQE in one test (NVIDIA#567) Signed-off-by: Andy Grove <[email protected]> * Enable using spark-submit to convert from csv to parquet (NVIDIA#565) Signed-off-by: Andy Grove <[email protected]> * xfail the Spark 3.1.0 integration tests that fail (NVIDIA#580) * xfail GpuTimeSub, arithmetic ops, and full outer join failures on 3.1.0 Signed-off-by: Thomas Graves <[email protected]> * xfail the rest of the 3.1.0 tests and enable 3.1.0 unit tests in the jenkins builds Signed-off-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]> * Fix unit tests when AQE is enabled (NVIDIA#558) * Fix scala tests when AQE is enabled Signed-off-by: Niranjan Artal <[email protected]> * fix broadcasthashjoin tests Signed-off-by: Niranjan Artal <[email protected]> * fix indentation Signed-off-by: Niranjan Artal <[email protected]> * addressed review comments Signed-off-by: Niranjan Artal <[email protected]> * addressed review comments Signed-off-by: Niranjan Artal <[email protected]> * addressed review comments Signed-off-by: Niranjan Artal <[email protected]> * Update buffer store to return compressed batches directly, add compression NVTX ranges (NVIDIA#572) * Update buffer store to return compressed batches directly, add compression NVTX ranges Signed-off-by: Jason Lowe <[email protected]> * Update parameter name for clarity Signed-off-by: Jason Lowe <[email protected]> * xfail the tpch spark 3.1.0 tests that fail (NVIDIA#588) Signed-off-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]> * Move GpuParquetScan/GpuOrcScan into Shim (NVIDIA#590) * Move GpuParquetScan to shim Signed-off-by: Thomas Graves <[email protected]> * Move scan overrides into shim Signed-off-by: Thomas Graves <[email protected]> * Rename GpuParquetScan object to match Signed-off-by: Thomas Graves <[email protected]> * Add tests for v2 datasources Signed-off-by: Thomas Graves <[email protected]> * Move OrcScan into shims Signed-off-by: Thomas Graves <[email protected]> * Fixes Signed-off-by: Thomas Graves <[email protected]> * Fix imports Signed-off-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]> * Filter nulls from joins where possible to improve performance. (NVIDIA#594) * Filter nulls from joins where possible to improve performance. Signed-off-by: Robert (Bobby) Evans <[email protected]> * Addressed review comments Signed-off-by: Robert (Bobby) Evans <[email protected]> * Updated patch for other shims * changelog generator Signed-off-by: Peixin Li <[email protected]> * only filter out labels for issue * add nightly workflow on github actions * fix format Co-authored-by: Andy Grove <[email protected]> Co-authored-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]> Co-authored-by: Niranjan Artal <[email protected]> Co-authored-by: Jason Lowe <[email protected]> Co-authored-by: Robert (Bobby) Evans <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Andy Grove <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Andy Grove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "coalesce HostColumnarToGpu" test fails if AQE is enabled, due to reasons explained in this PR. The test now explicitly disables AQE.